Mercurial > public > mercurial-scm > hg-stable
comparison mercurial/context.py @ 43023:008e74b34fb7
context: clarify the various mode in the filesadded method
The previous code was compact but a bit dense. The new proposed code deal with
each mode separately, there are some duplicated lines, but the meaning of each
mode stand out.
One of the benefit it to make it simpler to add further mode in the future.
Differential Revision: https://phab.mercurial-scm.org/D6931
| author | Pierre-Yves David <pierre-yves.david@octobus.net> |
|---|---|
| date | Fri, 27 Sep 2019 00:06:02 +0200 |
| parents | 2b869a515ba6 |
| children | 15badd621825 |
comparison
equal
deleted
inserted
replaced
| 43022:f3bcae1e9e23 | 43023:008e74b34fb7 |
|---|---|
| 451 def filesmodified(self): | 451 def filesmodified(self): |
| 452 modified = set(self.files()) | 452 modified = set(self.files()) |
| 453 modified.difference_update(self.filesadded()) | 453 modified.difference_update(self.filesadded()) |
| 454 modified.difference_update(self.filesremoved()) | 454 modified.difference_update(self.filesremoved()) |
| 455 return sorted(modified) | 455 return sorted(modified) |
| 456 | |
| 456 def filesadded(self): | 457 def filesadded(self): |
| 457 source = self._repo.ui.config('experimental', 'copies.read-from') | 458 source = self._repo.ui.config('experimental', 'copies.read-from') |
| 458 if (source == 'changeset-only' or | 459 filesadded = self._changeset.filesadded |
| 459 (source == 'compatibility' and | 460 if source == 'changeset-only': |
| 460 self._changeset.filesadded is not None)): | 461 if filesadded is None: |
| 461 return self._changeset.filesadded or [] | 462 filesadded = [] |
| 462 return scmutil.computechangesetfilesadded(self) | 463 elif source == 'compatibility': |
| 464 if filesadded is None: | |
| 465 filesadded = scmutil.computechangesetfilesadded(self) | |
| 466 else: | |
| 467 filesadded = scmutil.computechangesetfilesadded(self) | |
| 468 return filesadded | |
| 469 | |
| 463 def filesremoved(self): | 470 def filesremoved(self): |
| 464 source = self._repo.ui.config('experimental', 'copies.read-from') | 471 source = self._repo.ui.config('experimental', 'copies.read-from') |
| 465 if (source == 'changeset-only' or | 472 if (source == 'changeset-only' or |
| 466 (source == 'compatibility' and | 473 (source == 'compatibility' and |
| 467 self._changeset.filesremoved is not None)): | 474 self._changeset.filesremoved is not None)): |