Mercurial > public > mercurial-scm > hg-stable

comparison contrib/check-code.py @ 51691:1c23faf64ad4 stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: document reason and suggest alternative to exit code negation The check was introduced in f48b075ff088. We trust the explanation from there.
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Tue, 08 Oct 2024 15:54:59 +0200
parents 7a8ea1397816
children 3b6f25190157
comparison
equal deleted inserted replaced
51690:88715d0bef8d 51691:1c23faf64ad4
159 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), 159 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
160 (r'^stop\(\)', "don't use 'stop' as a shell function name"), 160 (r'^stop\(\)', "don't use 'stop' as a shell function name"),
161 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), 161 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
162 (r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"), 162 (r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"),
163 (r'^alias\b.*=', "don't use alias, use a function"), 163 (r'^alias\b.*=', "don't use alias, use a function"),
164 (r'if\s*!', "don't use '!' to negate exit status"), 164 # Solaris sh can not negate exit status with '!'
165 (
166 r'if\s*!',
167 "don't use '!' to negate exit status (use `||` or if/else)",
168 ),
165 (r'/dev/u?random', "don't use entropy, use /dev/zero"), 169 (r'/dev/u?random', "don't use entropy, use /dev/zero"),
166 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"), 170 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
167 ( 171 (
168 r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)', 172 r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',
169 "put a backslash-escaped newline after sed 'i' command", 173 "put a backslash-escaped newline after sed 'i' command",