Mercurial > public > mercurial-scm > hg-stable

comparison contrib/check-code.py @ 23134:22e76e370611

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
test-revert.t: fix wc check-code false positive
author Matt Mackall <mpm@selenic.com>
date Mon, 03 Nov 2014 11:06:51 -0600
parents 8afaf7cef35a
children e53f6b72a0e4
comparison
equal deleted inserted replaced
23133:336e19a473d9 23134:22e76e370611
92 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"), 92 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),
93 (r'(?<!hg )grep.*-a', "don't use 'grep -a', use in-line python"), 93 (r'(?<!hg )grep.*-a', "don't use 'grep -a', use in-line python"),
94 (r'sed.*-i', "don't use 'sed -i', use a temporary file"), 94 (r'sed.*-i', "don't use 'sed -i', use a temporary file"),
95 (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"), 95 (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"),
96 (r'echo -n', "don't use 'echo -n', use printf"), 96 (r'echo -n', "don't use 'echo -n', use printf"),
97 (r'(^| )\bwc\b[^|]*$\n(?!.*\(re\))', "filter wc output"), 97 (r'(^|\|\s*)\bwc\b[^|]*$\n(?!.*\(re\))', "filter wc output"),
98 (r'head -c', "don't use 'head -c', use 'dd'"), 98 (r'head -c', "don't use 'head -c', use 'dd'"),
99 (r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"), 99 (r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"),
100 (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"), 100 (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),
101 (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), 101 (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),
102 (r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"), 102 (r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"),