Mercurial > public > mercurial-scm > hg-stable
comparison mercurial/commands.py @ 46950:279df499511e
incoming: kill the `repo._subtoppath =` hack
We do the same as for `hg outgoing`, instead of relying on implicit passing
value by monkey punching them onto the repo object, we pass equivalent
information by argument to the proper function.
This is way cleaner.
Differential Revision: https://phab.mercurial-scm.org/D10416
| author | Pierre-Yves David <pierre-yves.david@octobus.net> |
|---|---|
| date | Wed, 14 Apr 2021 17:41:02 +0200 |
| parents | 3800a6aafb6f |
| children | 82366464190a |
comparison
equal
deleted
inserted
replaced
| 46949:3800a6aafb6f | 46950:279df499511e |
|---|---|
| 4349 ) | 4349 ) |
| 4350 return bookmarks.incoming(ui, repo, other) | 4350 return bookmarks.incoming(ui, repo, other) |
| 4351 finally: | 4351 finally: |
| 4352 other.close() | 4352 other.close() |
| 4353 | 4353 |
| 4354 repo._subtoppath = ui.expandpath(source) | 4354 return hg.incoming(ui, repo, source, opts) |
| 4355 try: | |
| 4356 return hg.incoming(ui, repo, source, opts) | |
| 4357 finally: | |
| 4358 del repo._subtoppath | |
| 4359 | 4355 |
| 4360 | 4356 |
| 4361 @command( | 4357 @command( |
| 4362 b'init', | 4358 b'init', |
| 4363 remoteopts, | 4359 remoteopts, |