Mercurial > public > mercurial-scm > hg-stable
comparison mercurial/hgweb/common.py @ 31444:2daeab02b4b1
hgweb: explicitly tests for None
Changeset 7dafa8d0e006 removed the mutable default value, but did not explicitly
tested for None. Such implicit testing can introduce semantic and performance
issue. We move to an explicit testing for None as recommended by PEP8:
https://www.python.org/dev/peps/pep-0008/#programming-recommendations
| author | Pierre-Yves David <pierre-yves.david@ens-lyon.org> |
|---|---|
| date | Wed, 15 Mar 2017 15:11:04 -0700 |
| parents | 7dafa8d0e006 |
| children | 161a87ed456e |
comparison
equal
deleted
inserted
replaced
| 31443:d4645ae6ba15 | 31444:2daeab02b4b1 |
|---|---|
| 94 def __init__(self, code, message=None, headers=None): | 94 def __init__(self, code, message=None, headers=None): |
| 95 if message is None: | 95 if message is None: |
| 96 message = _statusmessage(code) | 96 message = _statusmessage(code) |
| 97 Exception.__init__(self, message) | 97 Exception.__init__(self, message) |
| 98 self.code = code | 98 self.code = code |
| 99 self.headers = headers or [] | 99 if headers is None: |
| 100 headers = [] | |
| 101 self.headers = headers | |
| 100 | 102 |
| 101 class continuereader(object): | 103 class continuereader(object): |
| 102 def __init__(self, f, write): | 104 def __init__(self, f, write): |
| 103 self.f = f | 105 self.f = f |
| 104 self._write = write | 106 self._write = write |