Mercurial > public > mercurial-scm > hg-stable
comparison mercurial/httppeer.py @ 51798:7226f2626fb1
httppeer: avoid another bad reference before assignment warning
This wasn't a problem, because `b''` from the `AttributeError` handler is in
`bundle2.bundletypes`, so the following loop and conditional always run at least
once. But PyCharm can't figure that out on its own, and it took a little
exploring to figure out it wasn't a problem. The usage in `bundle2.writebundle`
is to look it up in the map of bundle types, so it will break in a more obvious
way in the unlikely event that the empty string is removed from the map in the
future.
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Mon, 29 Jul 2024 12:10:08 -0400 |
parents | 78f789a4c8a2 |
children | f4733654f144 |
comparison
equal
deleted
inserted
replaced
51797:78f789a4c8a2 | 51798:7226f2626fb1 |
---|---|
490 except AttributeError: | 490 except AttributeError: |
491 # servers older than d1b16a746db6 will send 'unbundle' as a | 491 # servers older than d1b16a746db6 will send 'unbundle' as a |
492 # boolean capability. They only support headerless/uncompressed | 492 # boolean capability. They only support headerless/uncompressed |
493 # bundles. | 493 # bundles. |
494 types = [b""] | 494 types = [b""] |
495 | |
496 type = b"" | |
497 | |
495 for x in types: | 498 for x in types: |
496 if x in bundle2.bundletypes: | 499 if x in bundle2.bundletypes: |
497 type = x | 500 type = x |
498 break | 501 break |
499 | 502 |