comparison contrib/check-code.py @ 16673:775a8d33e6f0

tests: unify the last sh tests This requires a slightly smarter check-code check for sed output filtering.
author Mads Kiilerich <mads@kiilerich.com>
date Wed, 25 Apr 2012 01:35:39 +0200
parents d046eb97d21e
children 525fdb738975
comparison
equal deleted inserted replaced
16672:d046eb97d21e 16673:775a8d33e6f0
90 90
91 uprefix = r"^ \$ " 91 uprefix = r"^ \$ "
92 utestpats = [ 92 utestpats = [
93 [ 93 [
94 (r'^(\S| $ ).*(\S[ \t]+|^[ \t]+)\n', "trailing whitespace on non-output"), 94 (r'^(\S| $ ).*(\S[ \t]+|^[ \t]+)\n', "trailing whitespace on non-output"),
95 (uprefix + r'.*\|\s*sed', "use regex test output patterns instead of sed"), 95 (uprefix + r'.*\|\s*sed[^|>\n]*\n',
96 "use regex test output patterns instead of sed"),
96 (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"), 97 (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),
97 (uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"), 98 (uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),
98 (uprefix + r'.*\|\| echo.*(fail|error)', 99 (uprefix + r'.*\|\| echo.*(fail|error)',
99 "explicit exit code checks unnecessary"), 100 "explicit exit code checks unnecessary"),
100 (uprefix + r'set -e', "don't use set -e"), 101 (uprefix + r'set -e', "don't use set -e"),