comparison mercurial/ui.py @ 45944:87e7dd8e7734

ui: ensure `getpass()` returns bytes Previously, this could return either bytes or str. I'm not sure which direction we should go in, but since the input is bytes, I guess bytes makes sense as output. `debuguigetpass` crashed because it assumed bytes would be returned, `sslcontext.load_cert_chain()` is happy with bytes or str if the type info in PyCharm is correct, and `smtplib.SMTP.login()` wants str. I couldn't figure out how to test this, because the test stalls for input with `echo test | hg debuguigetpass --config ui.interactive=1`, likely because it drains stdin before prompting. The custom input reading with `ui.nontty=1` does not. I'm also a bit concerned with all of this encoding/decoding. The existing code in the mail module uses `encoding.strfromlocal()`, but the username and password are ascii encoded/decoded in `mercurial.url.passwordmgr.find_user_password()` with `pycompat.{str,bytes}url()`. I'm not sure if this inconsistency could cause subtle compatability issues. Differential Revision: https://phab.mercurial-scm.org/D9375
author Matt Harbison <matt_harbison@yahoo.com>
date Mon, 23 Nov 2020 11:47:06 -0500
parents 9dc1351d0b5f
children 89a2afe31e82
comparison
equal deleted inserted replaced
45943:62329b759635 45944:87e7dd8e7734
1739 l = self._fin.readline() 1739 l = self._fin.readline()
1740 if not l: 1740 if not l:
1741 raise EOFError 1741 raise EOFError
1742 return l.rstrip(b'\n') 1742 return l.rstrip(b'\n')
1743 else: 1743 else:
1744 return getpass.getpass('') 1744 return encoding.strtolocal(getpass.getpass(''))
1745 except EOFError: 1745 except EOFError:
1746 raise error.ResponseExpected() 1746 raise error.ResponseExpected()
1747 1747
1748 def status(self, *msg, **opts): 1748 def status(self, *msg, **opts):
1749 '''write status message to output (if ui.quiet is False) 1749 '''write status message to output (if ui.quiet is False)