Mercurial > public > mercurial-scm > hg-stable
comparison mercurial/hgweb/hgweb_mod.py @ 7180:a42d27bc809d
hgweb: be sure to drain request data even in early error conditions
Thanks to Mads Kiilerich with noticing this. The hg client can only read data
after all the sent data has been read, so we have to read all the request data
even if we're not going to do anything with it (in error conditions). This
is not easy to fix in the client, because we're using Python's httplib, which
is strictly stateful. Abstracted the draining into a separate method.
| author | Dirkjan Ochtman <dirkjan@ochtman.nl> |
|---|---|
| date | Mon, 20 Oct 2008 10:15:26 +0200 |
| parents | 2cfdabe235fb |
| children | 6e9fe4ff9c54 |
comparison
equal
deleted
inserted
replaced
| 7179:3d080733a339 | 7180:a42d27bc809d |
|---|---|
| 89 | 89 |
| 90 cmd = req.form.get('cmd', [''])[0] | 90 cmd = req.form.get('cmd', [''])[0] |
| 91 if cmd and cmd in protocol.__all__: | 91 if cmd and cmd in protocol.__all__: |
| 92 try: | 92 try: |
| 93 if cmd in perms: | 93 if cmd in perms: |
| 94 self.check_perm(req, perms[cmd]) | 94 try: |
| 95 self.check_perm(req, perms[cmd]) | |
| 96 except ErrorResponse, inst: | |
| 97 if cmd == 'unbundle': | |
| 98 req.drain() | |
| 99 raise | |
| 95 method = getattr(protocol, cmd) | 100 method = getattr(protocol, cmd) |
| 96 return method(self.repo, req) | 101 return method(self.repo, req) |
| 97 except ErrorResponse, inst: | 102 except ErrorResponse, inst: |
| 98 req.respond(inst.code, protocol.HGTYPE) | 103 req.respond(inst.code, protocol.HGTYPE) |
| 99 if not inst.message: | 104 if not inst.message: |