Mercurial > public > mercurial-scm > hg-stable
comparison mercurial/hgweb/protocol.py @ 7180:a42d27bc809d
hgweb: be sure to drain request data even in early error conditions
Thanks to Mads Kiilerich with noticing this. The hg client can only read data
after all the sent data has been read, so we have to read all the request data
even if we're not going to do anything with it (in error conditions). This
is not easy to fix in the client, because we're using Python's httplib, which
is strictly stateful. Abstracted the draining into a separate method.
author | Dirkjan Ochtman <dirkjan@ochtman.nl> |
---|---|
date | Mon, 20 Oct 2008 10:15:26 +0200 |
parents | 57b954d8d003 |
children | f96c20e9b56a |
comparison
equal
deleted
inserted
replaced
7179:3d080733a339 | 7180:a42d27bc809d |
---|---|
115 heads = map(hex, repo.heads()) | 115 heads = map(hex, repo.heads()) |
116 return their_heads == [hex('force')] or their_heads == heads | 116 return their_heads == [hex('force')] or their_heads == heads |
117 | 117 |
118 # fail early if possible | 118 # fail early if possible |
119 if not check_heads(): | 119 if not check_heads(): |
120 length = int(req.env.get('CONTENT_LENGTH', 0)) | 120 req.drain() |
121 for s in util.filechunkiter(req, limit=length): | |
122 # drain incoming bundle, else client will not see | |
123 # response when run outside cgi script | |
124 pass | |
125 raise ErrorResponse(HTTP_OK, 'unsynced changes') | 121 raise ErrorResponse(HTTP_OK, 'unsynced changes') |
126 | 122 |
127 # do not lock repo until all changegroup data is | 123 # do not lock repo until all changegroup data is |
128 # streamed. save to temporary file. | 124 # streamed. save to temporary file. |
129 | 125 |