Mercurial > public > mercurial-scm > hg-stable
comparison mercurial/revlog.py @ 41247:a89b20a49c13
rust-cpython: using MissingAncestors from Python code
As precedently done with LazyAncestors on cpython.rs, we test for the
presence of the 'rustext' module.
incrementalmissingrevs() has two callers within the Mercurial core:
`setdiscovery.partialdiscovery` and the `only()` revset.
This move shows a significant discovery performance improvement
in cases where the baseline is slow: using perfdiscovery on the PyPy
repos, prepared with `contrib/discovery-helper <repo> 50 100`, we
get averaged medians of 403ms with the Rust version vs 742ms without
(about 45% better).
But there are still indications that performance can be worse in cases
the baseline is fast, possibly due to the conversion from Python to
Rust and back becoming the bottleneck. We could measure this on
mozilla-central in cases were the delta is just a few changesets.
This requires confirmation, but if that's the reason, then an
upcoming `partialdiscovery` fully in Rust should solve the problem.
Differential Revision: https://phab.mercurial-scm.org/D5551
| author | Georges Racinet <georges.racinet@octobus.net> |
|---|---|
| date | Fri, 30 Nov 2018 14:35:57 +0100 |
| parents | 3f807237dc94 |
| children | 1421d0487a61 |
comparison
equal
deleted
inserted
replaced
| 41246:619ee4039bd4 | 41247:a89b20a49c13 |
|---|---|
| 891 nullrev. | 891 nullrev. |
| 892 """ | 892 """ |
| 893 if common is None: | 893 if common is None: |
| 894 common = [nullrev] | 894 common = [nullrev] |
| 895 | 895 |
| 896 if rustext is not None: | |
| 897 return rustext.ancestor.MissingAncestors(self.index, common) | |
| 896 return ancestor.incrementalmissingancestors(self.parentrevs, common) | 898 return ancestor.incrementalmissingancestors(self.parentrevs, common) |
| 897 | 899 |
| 898 def findmissingrevs(self, common=None, heads=None): | 900 def findmissingrevs(self, common=None, heads=None): |
| 899 """Return the revision numbers of the ancestors of heads that | 901 """Return the revision numbers of the ancestors of heads that |
| 900 are not ancestors of common. | 902 are not ancestors of common. |