Mercurial > public > mercurial-scm > hg-stable
comparison contrib/check-code.py @ 31578:c0c4e14ee597
check-code: recommend util.urlreq when importing urlparse
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 21 Mar 2017 22:46:17 -0700 |
parents | 413b44003462 |
children | 772878ac930e |
comparison
equal
deleted
inserted
replaced
31577:b2a41a826d71 | 31578:c0c4e14ee597 |
---|---|
328 (r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"), | 328 (r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"), |
329 (r'^import Queue', "don't use Queue, use util.queue + util.empty"), | 329 (r'^import Queue', "don't use Queue, use util.queue + util.empty"), |
330 (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"), | 330 (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"), |
331 (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"), | 331 (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"), |
332 (r'^import SocketServer', "don't use SockerServer, use util.socketserver"), | 332 (r'^import SocketServer', "don't use SockerServer, use util.socketserver"), |
333 (r'^import urlparse', "don't use urlparse, use util.urlparse"), | 333 (r'^import urlparse', "don't use urlparse, use util.urlreq"), |
334 (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), | 334 (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), |
335 (r'^import cPickle', "don't use cPickle, use util.pickle"), | 335 (r'^import cPickle', "don't use cPickle, use util.pickle"), |
336 (r'^import pickle', "don't use pickle, use util.pickle"), | 336 (r'^import pickle', "don't use pickle, use util.pickle"), |
337 (r'^import httplib', "don't use httplib, use util.httplib"), | 337 (r'^import httplib', "don't use httplib, use util.httplib"), |
338 (r'^import BaseHTTPServer', "use util.httpserver instead"), | 338 (r'^import BaseHTTPServer', "use util.httpserver instead"), |