Mercurial > public > mercurial-scm > hg-stable

comparison contrib/check-code.py @ 36202:c38e9248f531

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
contrib: ban $RANDOM using check-code Differential Revision: https://phab.mercurial-scm.org/D2237
author Augie Fackler <augie@google.com>
date Tue, 13 Feb 2018 18:00:59 -0500
parents e28dedf4ff43
children 35d814fe2f30
comparison
equal deleted inserted replaced
36201:068f520754ca 36202:c38e9248f531
148 (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"), 148 (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
149 (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"), 149 (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
150 (r'grep.* -[ABC]', "don't use grep's context flags"), 150 (r'grep.* -[ABC]', "don't use grep's context flags"),
151 (r'find.*-printf', 151 (r'find.*-printf',
152 "don't use 'find -printf', it doesn't exist on BSD find(1)"), 152 "don't use 'find -printf', it doesn't exist on BSD find(1)"),
153 (r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),
153 ], 154 ],
154 # warnings 155 # warnings
155 [ 156 [
156 (r'^function', "don't use 'function', use old style"), 157 (r'^function', "don't use 'function', use old style"),
157 (r'^diff.*-\w*N', "don't use 'diff -N'"), 158 (r'^diff.*-\w*N', "don't use 'diff -N'"),