Mercurial > public > mercurial-scm > hg-stable

comparison mercurial/sslutil.py @ 31730:c777b12cdc9b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
sslutil: clarify internal documentation I ran into this python issue with an incomplete certificate chain on Windows recently, and this is the clarification that came from that experimenting. The comment I left on the bug tracker [1] with a reference to the CPython code [2] indicates that the original problem I had is a different bug, but happened to be mentioned under issue20916 on the Python bug tracker. [1] https://bz.mercurial-scm.org/show_bug.cgi?id=5313#c7 [2] https://hg.python.org/cpython/file/v2.7.12/Modules/_ssl.c#l628
author Matt Harbison <matt_harbison@yahoo.com>
date Wed, 29 Mar 2017 09:54:34 -0400
parents f819aa9dbbf9
children 9a86d936670f
comparison
equal deleted inserted replaced
31729:f1e0446e804c 31730:c777b12cdc9b
412 # If we're doing certificate verification and no CA certs are loaded, 412 # If we're doing certificate verification and no CA certs are loaded,
413 # that is almost certainly the reason why verification failed. Provide 413 # that is almost certainly the reason why verification failed. Provide
414 # a hint to the user. 414 # a hint to the user.
415 # Only modern ssl module exposes SSLContext.get_ca_certs() so we can 415 # Only modern ssl module exposes SSLContext.get_ca_certs() so we can
416 # only show this warning if modern ssl is available. 416 # only show this warning if modern ssl is available.
417 # The exception handler is here because of 417 # The exception handler is here to handle bugs around cert attributes:
418 # https://bugs.python.org/issue20916. 418 # https://bugs.python.org/issue20916#msg213479. (See issues5313.)
419 # When the main 20916 bug occurs, 'sslcontext.get_ca_certs()' is a
420 # non-empty list, but the following conditional is otherwise True.
419 try: 421 try:
420 if (caloaded and settings['verifymode'] == ssl.CERT_REQUIRED and 422 if (caloaded and settings['verifymode'] == ssl.CERT_REQUIRED and
421 modernssl and not sslcontext.get_ca_certs()): 423 modernssl and not sslcontext.get_ca_certs()):
422 ui.warn(_('(an attempt was made to load CA certificates but ' 424 ui.warn(_('(an attempt was made to load CA certificates but '
423 'none were loaded; see ' 425 'none were loaded; see '