Mercurial > public > mercurial-scm > hg-stable
comparison mercurial/hgweb/hgweb_mod.py @ 43106:d783f945a701
py3: finish porting iteritems() to pycompat and remove source transformer
This commit finishes porting .iteritems() to pycompat.iteritems()
for the mercurial package.
The translation of .iteritems() to .items() was the last conversion
performed by the source transformer. With the porting to pycompat
complete, we no longer have a need for the source transformer. So
the source transformer has been removed. Good riddance! The code
base is now compatible with Python 2 and Python 3.
For the record, as the person who introduced the source transformer,
it brings me joy to delete it. It accomplished its goal to facilitate
a port to Python 3 without overly burdening people on some painful
low-level differences between Python 2 and 3. It is unfortunate we
still have to wallpaper over many differences with the pycompat
shim. But it is what it is.
Differential Revision: https://phab.mercurial-scm.org/D7015
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Mon, 07 Oct 2019 00:04:04 -0400 |
parents | c59eb1560c44 |
children | ba50c8a95e2b |
comparison
equal
deleted
inserted
replaced
43105:649d3ac37a12 | 43106:d783f945a701 |
---|---|
394 if cmd == b'rev' and b'mercurial' in ua: | 394 if cmd == b'rev' and b'mercurial' in ua: |
395 req.qsparams[b'style'] = b'raw' | 395 req.qsparams[b'style'] = b'raw' |
396 | 396 |
397 if cmd == b'archive': | 397 if cmd == b'archive': |
398 fn = req.qsparams[b'node'] | 398 fn = req.qsparams[b'node'] |
399 for type_, spec in webutil.archivespecs.iteritems(): | 399 for type_, spec in pycompat.iteritems(webutil.archivespecs): |
400 ext = spec[2] | 400 ext = spec[2] |
401 if fn.endswith(ext): | 401 if fn.endswith(ext): |
402 req.qsparams[b'node'] = fn[: -len(ext)] | 402 req.qsparams[b'node'] = fn[: -len(ext)] |
403 req.qsparams[b'type'] = type_ | 403 req.qsparams[b'type'] = type_ |
404 else: | 404 else: |