comparison mercurial/hook.py @ 43106:d783f945a701

py3: finish porting iteritems() to pycompat and remove source transformer This commit finishes porting .iteritems() to pycompat.iteritems() for the mercurial package. The translation of .iteritems() to .items() was the last conversion performed by the source transformer. With the porting to pycompat complete, we no longer have a need for the source transformer. So the source transformer has been removed. Good riddance! The code base is now compatible with Python 2 and Python 3. For the record, as the person who introduced the source transformer, it brings me joy to delete it. It accomplished its goal to facilitate a port to Python 3 without overly burdening people on some painful low-level differences between Python 2 and 3. It is unfortunate we still have to wallpaper over many differences with the pycompat shim. But it is what it is. Differential Revision: https://phab.mercurial-scm.org/D7015
author Gregory Szorc <gregory.szorc@gmail.com>
date Mon, 07 Oct 2019 00:04:04 -0400
parents c59eb1560c44
children 8ff1ecfadcd1
comparison
equal deleted inserted replaced
43105:649d3ac37a12 43106:d783f945a701
153 if tr and tr.writepending(): 153 if tr and tr.writepending():
154 env[b'HG_PENDING'] = repo.root 154 env[b'HG_PENDING'] = repo.root
155 env[b'HG_HOOKTYPE'] = htype 155 env[b'HG_HOOKTYPE'] = htype
156 env[b'HG_HOOKNAME'] = name 156 env[b'HG_HOOKNAME'] = name
157 157
158 for k, v in args.iteritems(): 158 for k, v in pycompat.iteritems(args):
159 if callable(v): 159 if callable(v):
160 v = v() 160 v = v()
161 if isinstance(v, (dict, list)): 161 if isinstance(v, (dict, list)):
162 v = stringutil.pprint(v) 162 v = stringutil.pprint(v)
163 env[b'HG_' + k.upper()] = v 163 env[b'HG_' + k.upper()] = v