comparison mercurial/interfaces/modules.py @ 51994:d7f17819ae9e

interfaces: introduce and use a protocol class for the `mpatch` module See f2832de2a46c for details when this was done for the `bdiff` module. Two things worth pointing out- 1) The `cffi` module "inherits" the `pure` implementation of `patchedsize()` because of its wildcard import. 2) It's odd that the `mpatchError` lives in both `pure` and `cext` modules. I initially thought to move the exception into the new class, and make the existing class name an alias to the class in the new location, but the exception is created in C code by the `cext` module, so that won't work. I don't think a protocol class is approriate, because there's nothing special about the class to distinguish from any other `Exception`. Fortunately, nobody is catching this exception in core, so we can kick the can down the road.
author Matt Harbison <matt_harbison@yahoo.com>
date Sat, 05 Oct 2024 18:58:20 -0400
parents 54d9f496f07a
children
comparison
equal deleted inserted replaced
51993:5e2f0fec0a47 51994:d7f17819ae9e
71 def jsonescapeu8fast(self, u8chars: bytes, paranoid: bool) -> bytes: 71 def jsonescapeu8fast(self, u8chars: bytes, paranoid: bool) -> bytes:
72 """Convert a UTF-8 byte string to JSON-escaped form (fast path) 72 """Convert a UTF-8 byte string to JSON-escaped form (fast path)
73 73
74 Raises ValueError if non-ASCII characters have to be escaped. 74 Raises ValueError if non-ASCII characters have to be escaped.
75 """ 75 """
76
77
78 class MPatch(Protocol):
79 """A protocol class for the various mpatch module implementations."""
80
81 def patches(self, a: bytes, bins: List[bytes]) -> bytes:
82 ...
83
84 def patchedsize(self, orig: int, delta: bytes) -> int:
85 ...