Mercurial > public > mercurial-scm > hg-stable
comparison mercurial/localrepo.py @ 26323:ed884807dc48
tag: remove a mutable default argument
Mutable default arguments are know to the state of California to cause bugs. We
just added support of None for the underlying function, so nothing else the
required.
| author | Pierre-Yves David <pierre-yves.david@fb.com> |
|---|---|
| date | Thu, 24 Sep 2015 00:56:30 -0700 |
| parents | 2cd19782d2d4 |
| children | 2b31d8636f25 |
comparison
equal
deleted
inserted
replaced
| 26322:2cd19782d2d4 | 26323:ed884807dc48 |
|---|---|
| 538 replacing code that is expected to call a hook. | 538 replacing code that is expected to call a hook. |
| 539 """ | 539 """ |
| 540 return hook.hook(self.ui, self, name, throw, **args) | 540 return hook.hook(self.ui, self, name, throw, **args) |
| 541 | 541 |
| 542 @unfilteredmethod | 542 @unfilteredmethod |
| 543 def _tag(self, names, node, message, local, user, date, extra={}, | 543 def _tag(self, names, node, message, local, user, date, extra=None, |
| 544 editor=False): | 544 editor=False): |
| 545 if isinstance(names, str): | 545 if isinstance(names, str): |
| 546 names = (names,) | 546 names = (names,) |
| 547 | 547 |
| 548 branches = self.branchmap() | 548 branches = self.branchmap() |