Mercurial > public > mercurial-scm > hg-stable
comparison contrib/check-code.py @ 19380:ee07f9d142c9
check-code: do not warn on printf \\x or \\[1-9]
When there is a double backslash the following char does not have any special
meaning. So do not warn on this.
Remove the now obsolete no-check-code statement. (It was used wrongly anyway, it
skipped checking the entire file.)
| author | Simon Heimberg <simohe@besonet.ch> |
|---|---|
| date | Mon, 01 Jul 2013 06:50:58 +0200 |
| parents | 9de689d20230 |
| children | 5aeb03b48ab4 |
comparison
equal
deleted
inserted
replaced
| 19379:83d0df2ddf3f | 19380:ee07f9d142c9 |
|---|---|
| 66 (r'echo -n', "don't use 'echo -n', use printf"), | 66 (r'echo -n', "don't use 'echo -n', use printf"), |
| 67 (r'(^| )wc[^|]*$\n(?!.*\(re\))', "filter wc output"), | 67 (r'(^| )wc[^|]*$\n(?!.*\(re\))', "filter wc output"), |
| 68 (r'head -c', "don't use 'head -c', use 'dd'"), | 68 (r'head -c', "don't use 'head -c', use 'dd'"), |
| 69 (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"), | 69 (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"), |
| 70 (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), | 70 (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), |
| 71 (r'printf.*\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"), | 71 (r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"), |
| 72 (r'printf.*\\x', "don't use printf \\x, use Python"), | 72 (r'printf.*[^\\]\\x', "don't use printf \\x, use Python"), |
| 73 (r'\$\(.*\)', "don't use $(expr), use `expr`"), | 73 (r'\$\(.*\)', "don't use $(expr), use `expr`"), |
| 74 (r'rm -rf \*', "don't use naked rm -rf, target a directory"), | 74 (r'rm -rf \*', "don't use naked rm -rf, target a directory"), |
| 75 (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w', | 75 (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w', |
| 76 "use egrep for extended grep syntax"), | 76 "use egrep for extended grep syntax"), |
| 77 (r'/bin/', "don't use explicit paths for tools"), | 77 (r'/bin/', "don't use explicit paths for tools"), |