Mercurial > public > mercurial-scm > hg-stable
comparison contrib/check-code.py @ 22100:efd5b7eb3e6d
check-code: capture "wc" as a word
Otherwise entries such as "wcchange" give false negative
| author | Pierre-Yves David <pierre-yves.david@fb.com> |
|---|---|
| date | Sat, 02 Aug 2014 17:01:55 -0700 |
| parents | a5168eb9b2bc |
| children | 6fa40bd78bc8 |
comparison
equal
deleted
inserted
replaced
| 22099:9ed5e1053303 | 22100:efd5b7eb3e6d |
|---|---|
| 92 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"), | 92 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"), |
| 93 (r'(?<!hg )grep.*-a', "don't use 'grep -a', use in-line python"), | 93 (r'(?<!hg )grep.*-a', "don't use 'grep -a', use in-line python"), |
| 94 (r'sed.*-i', "don't use 'sed -i', use a temporary file"), | 94 (r'sed.*-i', "don't use 'sed -i', use a temporary file"), |
| 95 (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"), | 95 (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"), |
| 96 (r'echo -n', "don't use 'echo -n', use printf"), | 96 (r'echo -n', "don't use 'echo -n', use printf"), |
| 97 (r'(^| )wc[^|]*$\n(?!.*\(re\))', "filter wc output"), | 97 (r'(^| )\bwc\b[^|]*$\n(?!.*\(re\))', "filter wc output"), |
| 98 (r'head -c', "don't use 'head -c', use 'dd'"), | 98 (r'head -c', "don't use 'head -c', use 'dd'"), |
| 99 (r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"), | 99 (r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"), |
| 100 (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"), | 100 (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"), |
| 101 (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), | 101 (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), |
| 102 (r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"), | 102 (r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"), |