Mercurial > public > mercurial-scm > hg-stable

diff mercurial/posix.py @ 36954:0585337ea787

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cleanup: fix some latent open(path).read() et al calls we previously missed This pattern was banned by check-code way back in 1b4b82063ce2 (may of 2011), but due to a regular expression rewriting bug in check-code these particular callsites were never detected. Python 3.7 caught the bug, which then exposed these errors. Differential Revision: https://phab.mercurial-scm.org/D2863
author Augie Fackler <augie@google.com>
date Wed, 14 Mar 2018 15:39:28 -0400
parents ffa3026d4196
children e24802ea8dbd
line wrap: on
line diff
--- a/mercurial/posix.py	Wed Mar 14 11:16:45 2018 -0700
+++ b/mercurial/posix.py	Wed Mar 14 15:39:28 2018 -0400
@@ -264,7 +264,8 @@
                 # already exists.
                 target = 'checklink-target'
                 try:
-                    open(os.path.join(cachedir, target), 'w').close()
+                    fullpath = os.path.join(cachedir, target)
+                    open(fullpath, 'w').close()
                 except IOError as inst:
                     if inst[0] == errno.EACCES:
                         # If we can't write to cachedir, just pretend