Mercurial > public > mercurial-scm > hg-stable
diff mercurial/hgweb/hgweb_mod.py @ 2579:0875cda033fd
use __contains__, index or split instead of str.find
str.find return -1 when the substring is not found, -1 evaluate
to True and is a valid index, which can lead to bugs.
Using alternatives when possible makes the code clearer and less
prone to bugs. (and __contains__ is faster in microbenchmarks)
| author | Benoit Boissinot <benoit.boissinot@ens-lyon.org> |
|---|---|
| date | Sun, 09 Jul 2006 01:30:30 +0200 |
| parents | 1120302009d7 |
| children | a20a1bb0c396 |
line wrap: on
line diff
--- a/mercurial/hgweb/hgweb_mod.py Sat Jul 08 16:55:49 2006 +0200 +++ b/mercurial/hgweb/hgweb_mod.py Sun Jul 09 01:30:30 2006 +0200 @@ -462,7 +462,7 @@ continue remain = f[l:] if "/" in remain: - short = remain[:remain.find("/") + 1] # bleah + short = remain[:remain.index("/") + 1] # bleah files[short] = (f, None) else: short = os.path.basename(remain)