Mercurial > public > mercurial-scm > hg-stable
diff mercurial/revlog.py @ 39260:0a5b20c107a6
repository: remove storedeltachains from ifilestorage
The ifilestorage interface was bootstrapped from requirements of
callers outside the storage implementation (revlogs). I believe we
even made some members public so they could be part of the interface!
Historically, the changegroup code was a gross offender when it
came to accessing low-level storage primitives. There are a handful
of members on the ifilestorage interface that are/were used only
for changegroup code.
With the recent refactor of changegroup code and the establishment
of a formal API on the storage interface for producing revision
deltas, the changegroup code is no longer accessing these low-level
primitives related to delta generation directly. Instead, things
are abstracted away in the storage implementation.
This means we can remove elements from the storage interface that
are no longer needed.
We start with "storedeltachains."
We remove it from the interface. Then we make it a private
attribute and update all references.
.. api:: storedeltachains has been dropped from ifilestorage interface
.. api:: storedeltachains on revlog classes is now _storedeltachains
Differential Revision: https://phab.mercurial-scm.org/D4227
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Thu, 09 Aug 2018 16:11:24 -0700 |
| parents | b41d023a412a |
| children | 729082bb9938 |
line wrap: on
line diff
--- a/mercurial/revlog.py Thu Aug 09 16:02:14 2018 -0700 +++ b/mercurial/revlog.py Thu Aug 09 16:11:24 2018 -0700 @@ -627,7 +627,7 @@ p1r, p2r = revlog.rev(p1), revlog.rev(p2) # should we try to build a delta? - if prev != nullrev and revlog.storedeltachains: + if prev != nullrev and revlog._storedeltachains: tested = set() # This condition is true most of the time when processing # changegroup data into a generaldelta repo. The only time it @@ -1075,7 +1075,7 @@ raise RevlogError(_('unknown version (%d) in revlog %s') % (fmt, self.indexfile)) - self.storedeltachains = True + self._storedeltachains = True self._io = revlogio() if self.version == REVLOGV0: @@ -2995,7 +2995,7 @@ # cached, meaning less CPU for delta generation. There is # likely room to add a flag and/or config option to control this # behavior. - if deltaparentrev == nullrev and self.storedeltachains: + if deltaparentrev == nullrev and self._storedeltachains: baserev = prevrev # Revlog is configured to use full snapshot for a reason.