Mercurial > public > mercurial-scm > hg-stable
diff mercurial/ui.py @ 33005:149b68224b08
configitems: issue a devel warning when overriding default config
If the option is registered, there is already a default value available and
passing a new one is at best redundant. So we issue a deprecation warning in
this case.
(note: there will be case were the default value will not be as simple as what
is currently possible. We'll upgrade the configitems code to handle them in
time.)
| author | Pierre-Yves David <pierre-yves.david@octobus.net> |
|---|---|
| date | Sat, 17 Jun 2017 13:08:03 +0200 |
| parents | 28a65fd4b359 |
| children | 1aa05203f7f6 |
line wrap: on
line diff
--- a/mercurial/ui.py Sat Jun 17 12:33:59 2017 +0200 +++ b/mercurial/ui.py Sat Jun 17 13:08:03 2017 +0200 @@ -445,11 +445,17 @@ if default is _unset: default = None else: + item = self._knownconfig.get(section, {}).get(name) if default is _unset: default = None - item = self._knownconfig.get(section, {}).get(name) if item is not None: default = item.default + elif item is not None: + msg = ("specifying a default value for a registered " + "config item: '%s.%s' '%s'") + msg %= (section, name, default) + self.develwarn(msg, 1, 'warn-config-default') + alternates = [name] for n in alternates: