Mercurial > public > mercurial-scm > hg-stable
diff mercurial/commands.py @ 13135:1c1ca9d393f4 stable
tag: abort if not at a branch head (issue2552)
Since it's usually only desirable to make tag commits on top of branch
heads, abort if the working dir parent is not a branch head. -f/--force
may be passed to commit at a non-head anyway.
Does not abort if working dir parent is a named branch head but not a
topological head.
author | Kevin Bullock <kbullock@ringworld.org> |
---|---|
date | Mon, 06 Dec 2010 22:04:10 -0600 |
parents | ea3c93b53fdb |
children | 6320101a638c 827a1cc127bf |
line wrap: on
line diff
--- a/mercurial/commands.py Tue Dec 07 08:02:54 2010 +0100 +++ b/mercurial/commands.py Mon Dec 06 22:04:10 2010 -0600 @@ -3660,16 +3660,23 @@ Tags are used to name particular revisions of the repository and are very useful to compare different revisions, to go back to significant - earlier versions or to mark branch points as releases, etc. + earlier versions or to mark branch points as releases, etc. Changing + an existing tag is normally disallowed; use -f/--force to override. If no revision is given, the parent of the working directory is used, or tip if no revision is checked out. To facilitate version control, distribution, and merging of tags, - they are stored as a file named ".hgtags" which is managed - similarly to other project files and can be hand-edited if - necessary. The file '.hg/localtags' is used for local tags (not - shared among repositories). + they are stored as a file named ".hgtags" which is managed similarly + to other project files and can be hand-edited if necessary. This + also means that tagging creates a new commit. The file + ".hg/localtags" is used for local tags (not shared among + repositories). + + Tag commits are usually made at the head of a branch. If the parent + of the working directory is not a branch head, :hg:`tag` aborts; use + -f/--force to force the tag commit to be based on a non-head + changeset. See :hg:`help dates` for a list of formats valid for -d/--date. @@ -3712,8 +3719,13 @@ if n in repo.tags(): raise util.Abort(_('tag \'%s\' already exists ' '(use -f to force)') % n) - if not opts.get('local') and repo.dirstate.parents()[1] != nullid: - raise util.Abort(_('uncommitted merge')) + if not opts.get('local'): + p1, p2 = repo.dirstate.parents() + if p2 != nullid: + raise util.Abort(_('uncommitted merge')) + bheads = repo.branchheads() + if not opts.get('force') and bheads and p1 not in bheads: + raise util.Abort(_('not at a branch head (use -f to force)')) r = repo[rev_].node() if not message: @@ -4475,7 +4487,7 @@ _('[OPTION]... [FILE]...')), "tag": (tag, - [('f', 'force', None, _('replace existing tag')), + [('f', 'force', None, _('force tag')), ('l', 'local', None, _('make the tag local')), ('r', 'rev', '', _('revision to tag'), _('REV')),