Mercurial > public > mercurial-scm > hg-stable

diff mercurial/smartset.py @ 50631:1d937e495cd0

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Thu, 02 Feb 2023 17:35:47 +0100
parents 921a72735482
children f6cb926d4189
line wrap: on
line diff
--- a/mercurial/smartset.py	Thu Feb 02 17:35:38 2023 +0100
+++ b/mercurial/smartset.py	Thu Feb 02 17:35:47 2023 +0100
@@ -1127,7 +1127,7 @@
         This boldly assumes the other contains valid revs only.
         """
         # other not a smartset, make is so
-        if not util.safehasattr(other, b'isascending'):
+        if not util.safehasattr(other, 'isascending'):
             # filter out hidden revision
             # (this boldly assumes all smartset are pure)
             #