Mercurial > public > mercurial-scm > hg-stable

diff contrib/check-code.py @ 24836:1f9127c9239b stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: check os.path.join(*, '') not working correctly with Python 2.7.9 Since Python 2.7.9, "os.path.join(path, '')" doesn't append "os.sep" for UNC path (see issue4557 for detail).
author FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
date Wed, 22 Apr 2015 23:38:55 +0900
parents 65f1a29685ab
children ded7302e1c83
line wrap: on
line diff
--- a/contrib/check-code.py	Wed Apr 22 23:38:55 2015 +0900
+++ b/contrib/check-code.py	Wed Apr 22 23:38:55 2015 +0900
@@ -301,6 +301,8 @@
      "missing _() in ui message (use () to hide false-positives)"),
     (r'release\(.*wlock, .*lock\)', "wrong lock release order"),
     (r'\b__bool__\b', "__bool__ should be __nonzero__ in Python 2"),
+    (r'os\.path\.join\(.*, *(""|\'\')\)',
+     "use pathutil.normasprefix(path) instead of os.path.join(path, '')"),
   ],
   # warnings
   [