Mercurial > public > mercurial-scm > hg-stable

diff rust/rhg/src/commands/root.rs @ 45380:227281e76c22

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
rhg: Do not return error when when we really mean ok in commands Before when a command was successfull `Err(CommandErrorKind::Ok.into())` was returned which is an oxymoron. Using `Ok(())` when everything is ok seems more appropriate. Differential Revision: https://phab.mercurial-scm.org/D8864
author Antoine Cezar <antoine.cezar@octobus.net>
date Tue, 21 Jul 2020 10:39:30 +0200
parents 452ece5654c5
children 47997afadf08
line wrap: on
line diff
--- a/rust/rhg/src/commands/root.rs	Sat Aug 08 12:52:39 2020 -0700
+++ b/rust/rhg/src/commands/root.rs	Tue Jul 21 10:39:30 2020 +0200
@@ -29,7 +29,7 @@
         // TODO use formating macro
         self.ui.write_stdout(&[bytes.as_slice(), b"\n"].concat())?;
 
-        Err(CommandErrorKind::Ok.into())
+        Ok(())
     }
 
     fn display_error(&self, error: FindRootError) -> Result<(), CommandError> {