Mercurial > public > mercurial-scm > hg-stable

diff contrib/check-code.py @ 15334:24856af7237c stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: catch BaseException and os.path.relpath
author Matt Mackall <mpm@selenic.com>
date Fri, 21 Oct 2011 16:52:23 -0500
parents 4b71c17caeb8
children 572c22c88be6
line wrap: on
line diff
--- a/contrib/check-code.py	Fri Oct 21 16:52:16 2011 -0500
+++ b/contrib/check-code.py	Fri Oct 21 16:52:23 2011 -0500
@@ -176,6 +176,8 @@
      'hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead'),
     (r'opener\([^)]*\).read\(',
      "use opener.read() instead"),
+    (r'BaseException', 'not in Py2.4, use Exception'),
+    (r'os\.path\.relpath', 'os.path.relpath is not in Py2.5'),
     (r'opener\([^)]*\).write\(',
      "use opener.write() instead"),
     (r'[\s\(](open|file)\([^)]*\)\.read\(',