Mercurial > public > mercurial-scm > hg-stable
diff tests/test-filecache.py @ 18313:3e4a944c0d04
destroyed: keep the filecache in sync with __dict__ (issue3335) (issue3693) (issue3743)
We need to make sure that if X is in the filecache then it's also in the
filecache owner's __dict__, otherwise it will go out of sync:
repo.X # first access to X, records stat info in
# filecache and updates __dict__
repo._filecache.clear() # removes X from _filecache but it's still in __dict__
repo.invalidate() # iterates over _filecache and removes entries
# from __dict__, but X isn't in _filecache, so
# it's kept in __dict__
repo.X # X is fetched from __dict__, bypassing the filecache
| author | Idan Kamara <idankk86@gmail.com> |
|---|---|
| date | Wed, 09 Jan 2013 20:37:44 +0200 |
| parents | cfb6682961b8 |
| children | f36375576ed5 |
line wrap: on
line diff
--- a/tests/test-filecache.py Fri Jan 11 00:05:52 2013 +0200 +++ b/tests/test-filecache.py Wed Jan 09 20:37:44 2013 +0200 @@ -4,7 +4,7 @@ 'cacheable']): sys.exit(80) -from mercurial import util, scmutil, extensions +from mercurial import util, scmutil, extensions, hg, ui filecache = scmutil.filecache @@ -86,6 +86,21 @@ util.cachestat.cacheable = origcacheable util.cachestat.__init__ = originit +def test_filecache_synced(): + # test old behaviour that caused filecached properties to go out of sync + os.system('hg init && echo a >> a && hg ci -qAm.') + repo = hg.repository(ui.ui()) + # first rollback clears the filecache, but changelog to stays in __dict__ + repo.rollback() + repo.commit('.') + # second rollback comes along and touches the changelog externally + # (file is moved) + repo.rollback() + # but since changelog isn't under the filecache control anymore, we don't + # see that it changed, and return the old changelog without reconstructing + # it + repo.commit('.') + print 'basic:' print basic(fakerepo()) @@ -93,3 +108,4 @@ print 'fakeuncacheable:' print fakeuncacheable() +test_filecache_synced()