Mercurial > public > mercurial-scm > hg-stable
diff hgext/rebase.py @ 31440:406705701c2d
rebase: explicitly tests for None
Changeset 361bccce566a removed the mutable default value, but did not explicitly
tested for None. Such implicit checking can introduce semantic and performance
issue. We move to an explicit check for None as recommended by PEP8:
https://www.python.org/dev/peps/pep-0008/#programming-recommendations
| author | Pierre-Yves David <pierre-yves.david@ens-lyon.org> |
|---|---|
| date | Wed, 15 Mar 2017 15:03:43 -0700 |
| parents | 361bccce566a |
| children | f255b1811f5e |
line wrap: on
line diff
--- a/hgext/rebase.py Thu Mar 16 04:53:23 2017 +0530 +++ b/hgext/rebase.py Wed Mar 15 15:03:43 2017 -0700 @@ -725,7 +725,8 @@ destspace=None): """use revisions argument to define destination and rebase set """ - revf = revf or [] + if revf is None: + revf = [] # destspace is here to work around issues with `hg pull --rebase` see # issue5214 for details