Mercurial > public > mercurial-scm > hg-stable

diff hgext/amend.py @ 34889:554885e10868

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
amend: error out if the note is greater than 255bytes In obsmarker we can't store keys and values of more than 255 bytes in metadata. If we try to do so, ProgrammingError is raised. The note flag to amend stores the note in obsmetadata. If a user will try to store a larger note, he will encounter ProgrammingError which is wrong. We must error out early. Thanks to Yuya for warning about this. Differential Revision: https://phab.mercurial-scm.org/D1179
author Pulkit Goyal <7895pulkit@gmail.com>
date Thu, 19 Oct 2017 03:20:47 +0530
parents 530b7361e3a9
children 3e549546a6e9
line wrap: on
line diff
--- a/hgext/amend.py	Wed Oct 18 15:05:03 2017 -0700
+++ b/hgext/amend.py	Thu Oct 19 03:20:47 2017 +0530
@@ -16,6 +16,7 @@
 from mercurial import (
     cmdutil,
     commands,
+    error,
     registrar,
 )
 
@@ -45,6 +46,8 @@
 
     See :hg:`help commit` for more details.
     """
+    if len(opts['note']) > 255:
+        raise error.Abort(_("cannot store a note of more than 255 bytes"))
     with repo.wlock(), repo.lock():
         if not opts.get('logfile'):
             opts['message'] = opts.get('message') or repo['.'].description()