Mercurial > public > mercurial-scm > hg-stable
diff hgext/largefiles/overrides.py @ 48128:5ced12cfa41b
errors: raise InputError on bad revset to revrange() iff provided by the user
Most callers of `scmutil.revrange()` pass in a revset provided by the
user. If there are problems resolving that, it should result in an
`InputError` and exit code 10 (when using detailed exit
codes). However, there are also some callers that pass in revsets not
provided by the user. `InputError` is not appropriate in those
cases. This patch therefore introduces a wrapper around
`scmutil.revrange()` that simply converts the exception type. I put it
in `logcmdutil.py` since that seems to be the lowest-level module in
the (poorly defined) UI layer.
Differential Revision: https://phab.mercurial-scm.org/D11560
| author | Martin von Zweigbergk <martinvonz@google.com> |
|---|---|
| date | Tue, 28 Sep 2021 08:47:11 -0700 |
| parents | 82e142b9ad18 |
| children | 5105a9975407 |
line wrap: on
line diff
--- a/hgext/largefiles/overrides.py Tue Sep 28 09:08:43 2021 -0700 +++ b/hgext/largefiles/overrides.py Tue Sep 28 08:47:11 2021 -0700 @@ -1000,7 +1000,7 @@ numcached = 0 repo.firstpulled = revsprepull # for pulled() revset expression try: - for rev in scmutil.revrange(repo, lfrevs): + for rev in logcmdutil.revrange(repo, lfrevs): ui.note(_(b'pulling largefiles for revision %d\n') % rev) (cached, missing) = lfcommands.cachelfiles(ui, repo, rev) numcached += len(cached) @@ -1027,7 +1027,7 @@ lfrevs = kwargs.pop('lfrev', None) if lfrevs: opargs = kwargs.setdefault('opargs', {}) - opargs[b'lfrevs'] = scmutil.revrange(repo, lfrevs) + opargs[b'lfrevs'] = logcmdutil.revrange(repo, lfrevs) return orig(ui, repo, *args, **kwargs)