Mercurial > public > mercurial-scm > hg-stable
diff hgext/patchbomb.py @ 48128:5ced12cfa41b
errors: raise InputError on bad revset to revrange() iff provided by the user
Most callers of `scmutil.revrange()` pass in a revset provided by the
user. If there are problems resolving that, it should result in an
`InputError` and exit code 10 (when using detailed exit
codes). However, there are also some callers that pass in revsets not
provided by the user. `InputError` is not appropriate in those
cases. This patch therefore introduces a wrapper around
`scmutil.revrange()` that simply converts the exception type. I put it
in `logcmdutil.py` since that seems to be the lowest-level module in
the (poorly defined) UI layer.
Differential Revision: https://phab.mercurial-scm.org/D11560
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Tue, 28 Sep 2021 08:47:11 -0700 |
parents | ff2304dd3ba9 |
children | 6000f5b25c9b |
line wrap: on
line diff
--- a/hgext/patchbomb.py Tue Sep 28 09:08:43 2021 -0700 +++ b/hgext/patchbomb.py Tue Sep 28 08:47:11 2021 -0700 @@ -91,6 +91,7 @@ error, formatter, hg, + logcmdutil, mail, patch, pycompat, @@ -812,7 +813,7 @@ raise error.Abort(_(b"bookmark '%s' not found") % bookmark) revs = scmutil.bookmarkrevs(repo, bookmark) - revs = scmutil.revrange(repo, revs) + revs = logcmdutil.revrange(repo, revs) if outgoing: revs = _getoutgoing(repo, dest, revs) if bundle: