Mercurial > public > mercurial-scm > hg-stable
diff hgext/phabricator.py @ 48128:5ced12cfa41b
errors: raise InputError on bad revset to revrange() iff provided by the user
Most callers of `scmutil.revrange()` pass in a revset provided by the
user. If there are problems resolving that, it should result in an
`InputError` and exit code 10 (when using detailed exit
codes). However, there are also some callers that pass in revsets not
provided by the user. `InputError` is not appropriate in those
cases. This patch therefore introduces a wrapper around
`scmutil.revrange()` that simply converts the exception type. I put it
in `logcmdutil.py` since that seems to be the lowest-level module in
the (poorly defined) UI layer.
Differential Revision: https://phab.mercurial-scm.org/D11560
| author | Martin von Zweigbergk <martinvonz@google.com> |
|---|---|
| date | Tue, 28 Sep 2021 08:47:11 -0700 |
| parents | 7431f5ab0d2a |
| children | 5aafc3c5bdec |
line wrap: on
line diff
--- a/hgext/phabricator.py Tue Sep 28 09:08:43 2021 -0700 +++ b/hgext/phabricator.py Tue Sep 28 08:47:11 2021 -0700 @@ -1354,7 +1354,7 @@ """ opts = pycompat.byteskwargs(opts) revs = list(revs) + opts.get(b'rev', []) - revs = scmutil.revrange(repo, revs) + revs = logcmdutil.revrange(repo, revs) revs.sort() # ascending order to preserve topological parent/child in phab if not revs: @@ -2276,7 +2276,7 @@ if specs: raise error.InputError(_(b'cannot specify both DREVSPEC and --rev')) - drevmap = getdrevmap(repo, scmutil.revrange(repo, [revs])) + drevmap = getdrevmap(repo, logcmdutil.revrange(repo, [revs])) specs = [] unknown = [] for r, d in pycompat.iteritems(drevmap):