Mercurial > public > mercurial-scm > hg-stable

diff contrib/check-code.py @ 18575:667063b22a69

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: warn to use killdaemons instead of kill `cat PIDFILE` We have a bunch of tests that still use kill `cat hg.pid` or worse, kill `cat hg.pid`; while kill -0 `cat hg.pid`; sleep 0; done Cleaning these up to use tests/killdaemons.py is non-trivial, so for now we just add a warning.
author Kevin Bullock <kbullock@ringworld.org>
date Fri, 08 Feb 2013 19:32:56 +0000
parents 813b7a1f7036
children a343eccd5ee2
line wrap: on
line diff
--- a/contrib/check-code.py	Fri Feb 08 13:08:25 2013 +0100
+++ b/contrib/check-code.py	Fri Feb 08 19:32:56 2013 +0000
@@ -80,6 +80,7 @@
     (r'^diff.*-\w*N', "don't use 'diff -N'"),
     (r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),
     (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
+    (r'kill (`|\$\()', "don't use kill, use killdaemons.py")
   ]
 ]