Mercurial > public > mercurial-scm > hg-stable
diff mercurial/util.py @ 30181:7356e6b1f5b8
util: increase filechunkiter size to 128k
util.filechunkiter has been using a chunk size of 64k for more than 10 years,
also in years where Moore's law still was a law. It is probably ok to bump it
now and perhaps get a slight win in some cases.
Also, largefiles have been using 128k for a long time. Specifying that size
multiple times (or forgetting to do it) seems a bit stupid. Decreasing it to
64k also seems unfortunate.
Thus, we will set the default chunksize to 128k and use the default everywhere.
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Fri, 14 Oct 2016 01:53:15 +0200 |
| parents | 9b230a8e6008 |
| children | b496a464399c 6a8aff737a17 |
line wrap: on
line diff
--- a/mercurial/util.py Wed Oct 12 12:22:18 2016 +0200 +++ b/mercurial/util.py Fri Oct 14 01:53:15 2016 +0200 @@ -1684,9 +1684,9 @@ return ''.join(buf) -def filechunkiter(f, size=65536, limit=None): +def filechunkiter(f, size=131072, limit=None): """Create a generator that produces the data in the file size - (default 65536) bytes at a time, up to optional limit (default is + (default 131072) bytes at a time, up to optional limit (default is to read all data). Chunks may be less than size bytes if the chunk is the last chunk in the file, or the file is a socket or some other type of file that sometimes reads less data than is