Mercurial > public > mercurial-scm > hg-stable

diff contrib/check-code.py @ 28820:9848a6c77a9b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: reject import Queue, suggest util.queue class for py3 compat
author timeless <timeless@mozdev.org>
date Wed, 06 Apr 2016 20:08:18 +0000
parents c042b98a6ff8
children 75309badb485
line wrap: on
line diff
--- a/contrib/check-code.py	Wed Apr 06 20:07:51 2016 +0000
+++ b/contrib/check-code.py	Wed Apr 06 20:08:18 2016 +0000
@@ -315,6 +315,7 @@
     # XXX only catch mutable arguments on the first line of the definition
     (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
     (r'\butil\.Abort\b', "directly use error.Abort"),
+    (r'^import Queue', "don't use Queue, use util.queue + util.empty"),
   ],
   # warnings
   [