Mercurial > public > mercurial-scm > hg-stable
diff tests/test-wireproto-command-pushkey.t @ 40049:a732d70253b0
tests: don't be as verbose in wireprotov2 tests
I don't think that printing low-level I/O and frames is beneficial to
testing command-level functionality. Protocol-level testing, yes. But
command-level functionality shouldn't care about low-level details in
most cases. This output makes tests more verbose and harder to read.
It also makes them harder to maintain, as you need to glob over various
dynamic width fields.
Let's remove these low-level details from many of the wireprotov2
tests.
Differential Revision: https://phab.mercurial-scm.org/D4861
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Wed, 03 Oct 2018 09:48:22 -0700 |
| parents | 393e44324037 |
| children |
line wrap: on
line diff
--- a/tests/test-wireproto-command-pushkey.t Wed Oct 03 12:57:01 2018 -0700 +++ b/tests/test-wireproto-command-pushkey.t Wed Oct 03 09:48:22 2018 -0700 @@ -30,40 +30,7 @@ > EOF creating http peer for wire protocol version 2 sending pushkey command - s> *\r\n (glob) - s> Accept-Encoding: identity\r\n - s> accept: application/mercurial-exp-framing-0005\r\n - s> content-type: application/mercurial-exp-framing-0005\r\n - s> content-length: 105\r\n - s> host: $LOCALIP:$HGPORT\r\n (glob) - s> user-agent: Mercurial debugwireproto\r\n - s> \r\n - s> a\x00\x00\x01\x00\x01\x01\x11\xa2Dargs\xa4CkeyA@InamespaceIbookmarksCnewX(426bada5c67598ca65036d57d9e4b64b0c1ce7a0Cold@DnameGpushkey - s> makefile('rb', None) - s> HTTP/1.1 200 OK\r\n - s> Server: testing stub value\r\n - s> Date: $HTTP_DATE$\r\n - s> Content-Type: application/mercurial-exp-framing-0005\r\n - s> Transfer-Encoding: chunked\r\n - s> \r\n - s> 13\r\n - s> \x0b\x00\x00\x01\x00\x02\x011 - s> \xa1FstatusBok - s> \r\n - received frame(size=11; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=continuation) - s> 9\r\n - s> \x01\x00\x00\x01\x00\x02\x001 - s> \xf5 - s> \r\n - received frame(size=1; request=1; stream=2; streamflags=; type=command-response; flags=continuation) - s> 8\r\n - s> \x00\x00\x00\x01\x00\x02\x002 - s> \r\n - s> 0\r\n - s> \r\n - received frame(size=0; request=1; stream=2; streamflags=; type=command-response; flags=eos) response: True - (sent 2 HTTP requests and * bytes; received * bytes in responses) (glob) $ sendhttpv2peer << EOF > command listkeys @@ -71,41 +38,8 @@ > EOF creating http peer for wire protocol version 2 sending listkeys command - s> POST /api/exp-http-v2-0002/ro/listkeys HTTP/1.1\r\n - s> Accept-Encoding: identity\r\n - s> accept: application/mercurial-exp-framing-0005\r\n - s> content-type: application/mercurial-exp-framing-0005\r\n - s> content-length: 49\r\n - s> host: $LOCALIP:$HGPORT\r\n (glob) - s> user-agent: Mercurial debugwireproto\r\n - s> \r\n - s> )\x00\x00\x01\x00\x01\x01\x11\xa2Dargs\xa1InamespaceIbookmarksDnameHlistkeys - s> makefile('rb', None) - s> HTTP/1.1 200 OK\r\n - s> Server: testing stub value\r\n - s> Date: $HTTP_DATE$\r\n - s> Content-Type: application/mercurial-exp-framing-0005\r\n - s> Transfer-Encoding: chunked\r\n - s> \r\n - s> 13\r\n - s> \x0b\x00\x00\x01\x00\x02\x011 - s> \xa1FstatusBok - s> \r\n - received frame(size=11; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=continuation) - s> 35\r\n - s> -\x00\x00\x01\x00\x02\x001 - s> \xa1A@X(426bada5c67598ca65036d57d9e4b64b0c1ce7a0 - s> \r\n - received frame(size=45; request=1; stream=2; streamflags=; type=command-response; flags=continuation) - s> 8\r\n - s> \x00\x00\x00\x01\x00\x02\x002 - s> \r\n - s> 0\r\n - s> \r\n - received frame(size=0; request=1; stream=2; streamflags=; type=command-response; flags=eos) response: { b'@': b'426bada5c67598ca65036d57d9e4b64b0c1ce7a0' } - (sent 2 HTTP requests and * bytes; received * bytes in responses) (glob) $ cat error.log