Mercurial > public > mercurial-scm > hg-stable
diff mercurial/context.py @ 34351:ac0cd81e2f83
dirstate: use keyword arguments to clarify status()'s callers
The arguments are especially non-obvious because the order is
different from dirstate.walk().
Differential Revision: https://phab.mercurial-scm.org/D847
| author | Martin von Zweigbergk <martinvonz@google.com> |
|---|---|
| date | Fri, 29 Sep 2017 14:49:05 -0700 |
| parents | 255c761a52db |
| children | 80215865d154 |
line wrap: on
line diff
--- a/mercurial/context.py Fri Sep 29 14:19:36 2017 -0700 +++ b/mercurial/context.py Fri Sep 29 14:49:05 2017 -0700 @@ -1756,12 +1756,11 @@ def _dirstatestatus(self, match, ignored=False, clean=False, unknown=False): '''Gets the status from the dirstate -- internal use only.''' - listignored, listclean, listunknown = ignored, clean, unknown subrepos = [] if '.hgsub' in self: subrepos = sorted(self.substate) - cmp, s = self._repo.dirstate.status(match, subrepos, listignored, - listclean, listunknown) + cmp, s = self._repo.dirstate.status(match, subrepos, ignored=ignored, + clean=clean, unknown=unknown) # check for any possibly clean files fixup = [] @@ -1770,7 +1769,7 @@ s.modified.extend(modified2) s.deleted.extend(deleted2) - if fixup and listclean: + if fixup and clean: s.clean.extend(fixup) self._poststatusfixup(s, fixup)