Mercurial > public > mercurial-scm > hg-stable
diff tests/test-check-interfaces.py @ 39258:b518d495a560
repository: formalize interfaces for revision deltas and requests
Now that we've sufficiently abstracted how revision deltas are
produced in changegroup code, we can now start the process of
formalizing that as part of the interfaces defined in the
repository module.
This commit essentially converts the revisiondelta and
revisiondeltarequest classes into well-defined interfaces. This
is not strictly necessary. But I want all types formalized by the
storage interface to have interfaces. This makes it much easier
to test for interface conformance and for implementing new
storage backends.
Because the interface is documented, comments and docstrings from
changegroup.py have been dropped.
Differential Revision: https://phab.mercurial-scm.org/D4225
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Thu, 09 Aug 2018 15:40:14 -0700 |
| parents | c82ea938efbb |
| children | b41d023a412a |
line wrap: on
line diff
--- a/tests/test-check-interfaces.py Thu Aug 09 14:31:25 2018 -0700 +++ b/tests/test-check-interfaces.py Thu Aug 09 15:40:14 2018 -0700 @@ -21,6 +21,7 @@ verify as ziverify, ) from mercurial import ( + changegroup, bundlerepo, filelog, httppeer, @@ -196,4 +197,29 @@ # Conforms to imanifestdict. checkzobject(mctx.read()) + ziverify.verifyClass(repository.irevisiondelta, + changegroup.revisiondelta) + ziverify.verifyClass(repository.irevisiondeltarequest, + changegroup.revisiondeltarequest) + + rd = changegroup.revisiondelta( + node=b'', + p1node=b'', + p2node=b'', + basenode=b'', + linknode=b'', + flags=b'', + baserevisionsize=None, + revision=b'', + delta=None) + checkzobject(rd) + + rdr = changegroup.revisiondeltarequest( + node=b'', + linknode=b'', + p1node=b'', + p2node=b'', + basenode=b'') + checkzobject(rdr) + main()