Mercurial > public > mercurial-scm > hg-stable
diff mercurial/dirstate.py @ 22913:cb4449921a1d
status: create class for status lists
Callers of various status() methods (on dirstate, context, repo) get a
tuple of 7 elements, where each element is a list of files. This
results in lots of uses of indexes where names would be much more
readable. For example, "status.ignored" seems clearer than "status[4]"
[1]. So, let's introduce a simple named tuple containing the 7 status
fields: modified, added, removed, deleted, unknown, ignored, clean.
This patch introduces the class and updates the status methods to
return instances of it. Later patches will update the callers.
[1] Did you even notice that it should have been "status[5]"?
(tweaked by mpm to introduce the class in scmutil and only change one user)
author | Martin von Zweigbergk <martinvonz@gmail.com> |
---|---|
date | Fri, 10 Oct 2014 14:32:36 -0700 |
parents | 509e2cbee679 |
children | 4d680deb0d9e |
line wrap: on
line diff
--- a/mercurial/dirstate.py Fri Oct 03 21:21:20 2014 -0700 +++ b/mercurial/dirstate.py Fri Oct 10 14:32:36 2014 -0700 @@ -908,8 +908,8 @@ elif state == 'r': radd(fn) - return (lookup, (modified, added, removed, deleted, unknown, ignored, - clean)) + return (lookup, scmutil.status(modified, added, removed, deleted, + unknown, ignored, clean)) def matches(self, match): '''