Mercurial > public > mercurial-scm > hg-stable
diff mercurial/config.py @ 31383:d30fb3de4b40
config: avoid using a mutable default
Nothing *currently* mutates this list, but the moment something does it'll be
shared between all config instances. Avoid this eventuality.
author | Martijn Pieters <mjpieters@fb.com> |
---|---|
date | Sun, 12 Mar 2017 12:56:12 -0700 |
parents | c920efa9d34b |
children | a7c687c35119 |
line wrap: on
line diff
--- a/mercurial/config.py Fri Aug 05 14:09:04 2016 +0200 +++ b/mercurial/config.py Sun Mar 12 12:56:12 2017 -0700 @@ -18,11 +18,11 @@ ) class config(object): - def __init__(self, data=None, includepaths=[]): + def __init__(self, data=None, includepaths=None): self._data = {} self._source = {} self._unset = [] - self._includepaths = includepaths + self._includepaths = includepaths or [] if data: for k in data._data: self._data[k] = data[k].copy()