Mercurial > public > mercurial-scm > hg-stable
diff contrib/check-py3-compat.py @ 28584:d69172ddfdca
tests: try to import modules with Python 3
All of mercurial.* is now using absolute_import. Most of
mercurial.* is able to ast parse with Python 3. The next big
hurdle is being able to import modules using Python 3.
This patch adds testing of hgext.* and mercurial.* module imports
in Python 3. As the new test output shows, most modules can't
import under Python 3. However, many of the failures are due
to a common problem in a highly imported module (e.g. the bytes vs
str issue in node.py).
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Sat, 12 Mar 2016 14:05:23 -0800 |
| parents | 260ce2eed951 |
| children | 1c22400db72d |
line wrap: on
line diff
--- a/contrib/check-py3-compat.py Fri Mar 18 16:15:12 2016 -0700 +++ b/contrib/check-py3-compat.py Sat Mar 12 14:05:23 2016 -0800 @@ -10,7 +10,10 @@ from __future__ import absolute_import, print_function import ast +import imp +import os import sys +import traceback def check_compat_py2(f): """Check Python 3 compatibility for a file with Python 2""" @@ -47,6 +50,27 @@ print('%s: invalid syntax: %s' % (f, e)) return + # Try to import the module. + # For now we only support mercurial.* and hgext.* modules because figuring + # out module paths for things not in a package can be confusing. + if f.startswith(('hgext/', 'mercurial/')) and not f.endswith('__init__.py'): + assert f.endswith('.py') + name = f.replace('/', '.')[:-3] + with open(f, 'r') as fh: + try: + imp.load_module(name, fh, '', ('py', 'r', imp.PY_SOURCE)) + except Exception as e: + exc_type, exc_value, tb = sys.exc_info() + frame = traceback.extract_tb(tb)[-1] + + if frame.filename: + filename = os.path.basename(frame.filename) + print('%s: error importing: <%s> %s (error at %s:%d)' % ( + f, type(e).__name__, e, filename, frame.lineno)) + else: + print('%s: error importing module: <%s> %s (line %d)' % ( + f, type(e).__name__, e, frame.lineno)) + if __name__ == '__main__': if sys.version_info[0] == 2: fn = check_compat_py2