Mercurial > public > mercurial-scm > hg-stable
diff mercurial/dispatch.py @ 29129:e6dfb0e4eeef
dispatch: add fail-* family of hooks
The post-* family of hooks will not run in case a command fails (i.e.
raises an exception). This makes it inconvenient to hook into events
such as doing something in case of a failed push.
We catch all exceptions to run the failure hook. I am not sure if this
is too aggressive, but tests apparently pass.
| author | Jordi Guti?rrez Hermoso <jordigh@octave.org> |
|---|---|
| date | Thu, 28 Apr 2016 10:37:47 -0400 |
| parents | f1081aea19b1 |
| children | 12769703d4ba |
line wrap: on
line diff
--- a/mercurial/dispatch.py Fri May 06 22:21:32 2016 +0530 +++ b/mercurial/dispatch.py Thu Apr 28 10:37:47 2016 -0400 @@ -633,10 +633,16 @@ # run pre-hook, and abort if it fails hook.hook(lui, repo, "pre-%s" % cmd, True, args=" ".join(fullargs), pats=cmdpats, opts=cmdoptions) - ret = _runcommand(ui, options, cmd, d) - # run post-hook, passing command result - hook.hook(lui, repo, "post-%s" % cmd, False, args=" ".join(fullargs), - result=ret, pats=cmdpats, opts=cmdoptions) + try: + ret = _runcommand(ui, options, cmd, d) + # run post-hook, passing command result + hook.hook(lui, repo, "post-%s" % cmd, False, args=" ".join(fullargs), + result=ret, pats=cmdpats, opts=cmdoptions) + except Exception: + # run failure hook and re-raise + hook.hook(lui, repo, "fail-%s" % cmd, False, args=" ".join(fullargs), + pats=cmdpats, opts=cmdoptions) + raise return ret def _getlocal(ui, rpath, wd=None):