diff mercurial/changegroup.py @ 26859:e7c618cee8df stable

hooks: fix hooks not firing if prechangegroup was set (issue4934) We need to call delayupdate again after writing to the changelog. Otherwise the prechangegroup hook consumes the delayupdate subscription and future hooks don't see the pending changes (see issue 4934 for more details). Adds a test that triggers the prechangegroup hook before the pretxnchangegroup hook and verifies that the output of pretxnchangegroup doesn't change.
author Durham Goode <durham@fb.com>
date Tue, 03 Nov 2015 17:13:27 -0800
parents 520defbc0335
children fa7f8b686633
line wrap: on
line diff
--- a/mercurial/changegroup.py	Tue Nov 03 16:58:13 2015 -0800
+++ b/mercurial/changegroup.py	Tue Nov 03 17:13:27 2015 -0800
@@ -406,6 +406,10 @@
                              % (changesets, revisions, files, htext))
             repo.invalidatevolatilesets()
 
+            # Call delayupdate again to ensure the transaction writepending
+            # subscriptions are still in place.
+            cl.delayupdate(tr)
+
             if changesets > 0:
                 if 'node' not in tr.hookargs:
                     tr.hookargs['node'] = hex(cl.node(clstart))