Mercurial > public > mercurial-scm > hg-stable
diff rust/hg-core/src/lock.rs @ 50003:e98fd81bb151
rust-clippy: fix most warnings in `hg-core`
All of these are simple changes that for the most part are clear improvements
and the rest are at most equivalent.
The remaining warnings have to be fixed either with a bigger refactor like for
the nested "revlog" module, or in the dependency `bytes-cast`, which we own.
This will be done sometime in the future.
| author | Rapha?l Gom?s <rgomes@octobus.net> |
|---|---|
| date | Mon, 09 Jan 2023 19:18:43 +0100 |
| parents | 29cf3167e459 |
| children | db7dbe6f7bb2 |
line wrap: on
line diff
--- a/rust/hg-core/src/lock.rs Mon Jan 09 19:14:14 2023 +0100 +++ b/rust/hg-core/src/lock.rs Mon Jan 09 19:18:43 2023 +0100 @@ -107,7 +107,7 @@ fn lock_should_be_broken(data: &Option<String>) -> bool { (|| -> Option<bool> { let (prefix, pid) = data.as_ref()?.split_once(':')?; - if prefix != &*LOCK_PREFIX { + if prefix != *LOCK_PREFIX { return Some(false); } let process_is_running; @@ -144,6 +144,8 @@ /// Same as https://github.com/python/cpython/blob/v3.10.0/Modules/socketmodule.c#L5414 const BUFFER_SIZE: usize = 1024; + // This cast is *needed* for platforms with signed chars + #[allow(clippy::unnecessary_cast)] let mut buffer = [0 as libc::c_char; BUFFER_SIZE]; let hostname_bytes = unsafe { let result = libc::gethostname(buffer.as_mut_ptr(), BUFFER_SIZE);