Mercurial > public > mercurial-scm > hg-stable

diff tests/test-extdata.t @ 42576:ea6558db1011

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
extdata: avoid crashing inside subprocess when we get a revset parse error Differential Revision: https://phab.mercurial-scm.org/D6616
author Augie Fackler <augie@google.com>
date Mon, 08 Jul 2019 14:01:01 -0400
parents eec65b706caf
children ebee234d952a
line wrap: on
line diff
--- a/tests/test-extdata.t	Mon Jul 08 13:57:44 2019 -0400
+++ b/tests/test-extdata.t	Mon Jul 08 14:01:01 2019 -0400
@@ -66,9 +66,14 @@
   > 9de260b1e88e
   > EOF
 
-BUG: this should print the revset parse error
-  $ hg log -qr "extdata(badparse)" 2>&1 | grep ValueError
-  ValueError: Mixing iteration and read methods would lose data
+It might be nice if this error message mentioned where the bad string
+came from (eg line X of extdata source S), but the important thing is
+that we don't crash before we can print the parse error.
+  $ hg log -qr "extdata(badparse)"
+  hg: parse error at 0: not a prefix: +
+  (+---------------------------------------+
+   ^ here)
+  [255]
 
 test template support: