Mercurial > public > mercurial-scm > hg-stable

diff contrib/check-code.py @ 25178:ebc41dae840a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: drop the yield inside try/finally ban This is now possible with Python 2.6.
author Pierre-Yves David <pierre-yves.david@fb.com>
date Mon, 18 May 2015 12:56:59 -0500
parents d28cc89d92f0
children 3ff2a5dc7c20
line wrap: on
line diff
--- a/contrib/check-code.py	Mon May 18 15:34:42 2015 -0400
+++ b/contrib/check-code.py	Mon May 18 12:56:59 2015 -0500
@@ -217,9 +217,6 @@
     (r'(\w|\)),\w', "missing whitespace after ,"),
     (r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"),
     (r'^\s+(\w|\.)+=\w[^,()\n]*$', "missing whitespace in assignment"),
-    (r'(\s+)try:\n((?:\n|\1\s.*\n)*?)\1\s*yield\b.*?'
-     r'((?:\n|\1\s.*\n)+?)\1finally:',
-     'no yield inside try/finally in Python 2.4'),
     (r'.{81}', "line too long"),
     (r' x+[xo][\'"]\n\s+[\'"]x', 'string join across lines with no space'),
     (r'[^\n]\Z', "no trailing newline"),