Mercurial > public > mercurial-scm > hg-stable
diff contrib/check-code.py @ 16485:f48b075ff088 stable
tests: solaris sh can not negate exit status with '!'
| author | Mads Kiilerich <mads@kiilerich.com> |
|---|---|
| date | Mon, 23 Apr 2012 01:39:26 +0200 |
| parents | 3c4910364797 |
| children | ac987a9d8d49 |
line wrap: on
line diff
--- a/contrib/check-code.py Mon Apr 23 01:39:26 2012 +0200 +++ b/contrib/check-code.py Mon Apr 23 01:39:26 2012 +0200 @@ -73,6 +73,7 @@ (r'^stop\(\)', "don't use 'stop' as a shell function name"), (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), (r'^alias\b.*=', "don't use alias, use a function"), + (r'if\s*!', "don't use '!' to negate exit status"), ], # warnings []